From: paco <paco@voltanet.io>
Date: Mon, 25 Jun 2018 10:55:53 +0000 (+0200)
Subject: ospfd: OoB access (Coverity 1399304 1399286)
X-Git-Tag: frr-6.1-dev~258^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=13f0e434430d20065d889163872b5c6dc22d3db9;p=matthieu%2Ffrr.git

ospfd: OoB access (Coverity 1399304 1399286)

Signed-off-by: F. Aragon <paco@voltanet.io>
---

diff --git a/ospfd/ospf_vty.c b/ospfd/ospf_vty.c
index 7d748419fa..ddf9133ed9 100644
--- a/ospfd/ospf_vty.c
+++ b/ospfd/ospf_vty.c
@@ -8166,6 +8166,11 @@ DEFUN (ospf_redistribute_instance_source,
 
 	source = proto_redistnum(AFI_IP, argv[idx_ospf_table]->text);
 
+	if (source < 0) {
+		vty_out(vty, "Unknown instance redistribution\n");
+		return CMD_WARNING_CONFIG_FAILED;
+	}
+
 	instance = strtoul(argv[idx_number]->arg, NULL, 10);
 
 	if ((source == ZEBRA_ROUTE_OSPF) && !ospf->instance) {