From: Donatas Abraitis <donatas@opensourcerouting.org>
Date: Wed, 25 Oct 2023 04:52:38 +0000 (+0300)
Subject: bgpd: Drop unnecessary null-termination for fqdn
X-Git-Tag: base_10.0~336^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=0df64642169c19f6dce5fd8f97f9c59983cdb7f5;p=mirror%2Ffrr.git

bgpd: Drop unnecessary null-termination for fqdn

str[len] is already null terminated before:

```
		if (len > BGP_MAX_HOSTNAME) {
			memcpy(&str, data, BGP_MAX_HOSTNAME);
			str[BGP_MAX_HOSTNAME] = '\0';
		} else if (len) {
			memcpy(&str, data, len);
			str[len] = '\0';
		}
```

CID: 1569357

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
---

diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c
index f955c50577..08c3cbdea9 100644
--- a/bgpd/bgp_packet.c
+++ b/bgpd/bgp_packet.c
@@ -3307,8 +3307,6 @@ static void bgp_dynamic_capability_fqdn(uint8_t *pnt, int action,
 		data += len;
 
 		if (len) {
-			str[len] = '\0';
-
 			XFREE(MTYPE_BGP_PEER_HOST, peer->hostname);
 			XFREE(MTYPE_BGP_PEER_HOST, peer->domainname);