From: Reuben Dowle <reuben.dowle@4rf.com>
Date: Wed, 17 Feb 2021 00:49:06 +0000 (+1300)
Subject: nhrpd: Fix multicast crash due to dangling references to nhrp peers
X-Git-Tag: base_8.0~145^2~16
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=0da7701aa2da8ff638f4271b982432411fbd9392;p=matthieu%2Ffrr.git

nhrpd: Fix multicast crash due to dangling references to nhrp peers

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
---

diff --git a/nhrpd/nhrp_multicast.c b/nhrpd/nhrp_multicast.c
index 0c5de838ad..6feab210c9 100755
--- a/nhrpd/nhrp_multicast.c
+++ b/nhrpd/nhrp_multicast.c
@@ -62,8 +62,8 @@ static void nhrp_multicast_forward_nbma(union sockunion *nbma_addr, struct inter
 	if(p && p->online) {
 		/* Send packet */
 		nhrp_multicast_send(p, pkt);
-		nhrp_peer_unref(p);
 	}
+	nhrp_peer_unref(p);
 }
 
 static void nhrp_multicast_forward_cache(struct nhrp_cache *c, void *pctx)