From: Donald Sharp <sharpd@nvidia.com>
Date: Tue, 25 Mar 2025 21:35:47 +0000 (-0400)
Subject: tests: Add ripng aggregate address testing
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=0c7cd73a7b3ef4f962bfe01bd8626268f7a55f09;p=mirror%2Ffrr.git

tests: Add ripng aggregate address testing

Looking at gcov and noticed that ripngd does not
test any aggregate address addition/deletion
to ensure that it works.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
---

diff --git a/tests/topotests/ripng_aggregate_address/__init__.py b/tests/topotests/ripng_aggregate_address/__init__.py
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/topotests/ripng_aggregate_address/r2/frr.conf b/tests/topotests/ripng_aggregate_address/r2/frr.conf
new file mode 100644
index 0000000000..fb9d6702c4
--- /dev/null
+++ b/tests/topotests/ripng_aggregate_address/r2/frr.conf
@@ -0,0 +1,14 @@
+!
+int lo
+ ipv6 address 2001:db8:2::1/64
+!
+int r2-eth0
+ ipv6 address 2001:db8::2/64
+!
+router ripng
+ redistribute connected
+ network 2001:db8::/64
+ network 2001:db8:2::1/64
+ timers basic 5 15 10
+exit
+
diff --git a/tests/topotests/ripng_aggregate_address/r3/frr.conf b/tests/topotests/ripng_aggregate_address/r3/frr.conf
new file mode 100644
index 0000000000..d9b542af8e
--- /dev/null
+++ b/tests/topotests/ripng_aggregate_address/r3/frr.conf
@@ -0,0 +1,23 @@
+!
+int lo
+ ipv6 address 2001:db8:3::1/64
+!
+int r3-eth0
+ ipv6 address 2001:db8::3/64
+!
+debug ripng events
+debug ripng packet
+debug ripng zebra
+router ripng
+ aggregate-address 33::/64
+ redistribute connected
+ redistribute static
+ network 2001:db8::/64
+ network 2001:db8:3::1/64
+ timers basic 5 15 10
+exit
+
+ipv6 route 33::1/128 lo
+ipv6 route 33::2/128 lo
+ipv6 route 33::3/128 lo
+ipv6 route 33::4/128 lo
diff --git a/tests/topotests/ripng_aggregate_address/test_ripng_aggregate_address.py b/tests/topotests/ripng_aggregate_address/test_ripng_aggregate_address.py
new file mode 100644
index 0000000000..05980a0e13
--- /dev/null
+++ b/tests/topotests/ripng_aggregate_address/test_ripng_aggregate_address.py
@@ -0,0 +1,106 @@
+#!/usr/bin/env python
+# SPDX-License-Identifier: ISC
+
+# Copyright (c) 2025 by
+# Donald Sharp <sharpd@nvidia.com>
+#
+
+"""
+Test if aggregate-address for ripng basic functionality works.
+"""
+
+import os
+import sys
+import json
+import pytest
+import functools
+
+CWD = os.path.dirname(os.path.realpath(__file__))
+sys.path.append(os.path.join(CWD, "../"))
+
+# pylint: disable=C0413
+from lib import topotest
+from lib.topogen import Topogen, get_topogen
+
+pytestmark = [pytest.mark.ripngd]
+
+
+def setup_module(mod):
+    topodef = {"s1": ( "r2", "r3")}
+    tgen = Topogen(topodef, mod.__name__)
+    tgen.start_topology()
+
+    router_list = tgen.routers()
+
+    for _, (rname, router) in enumerate(router_list.items(), 1):
+        router.load_frr_config(os.path.join(CWD, "{}/frr.conf".format(rname)))
+
+    tgen.start_router()
+
+
+def teardown_module():
+    tgen = get_topogen()
+    tgen.stop_topology()
+
+
+def test_ripng_aggregate_address():
+    tgen = get_topogen()
+
+    if tgen.routers_have_failure():
+        pytest.skip(tgen.errors)
+
+    r3 = tgen.gears["r3"]
+    r2 = tgen.gears["r2"]
+
+    def _show_routes(nh_num):
+        output = json.loads(r2.vtysh_cmd("show ipv6 route ripng json"))
+        expected = {
+            "33::/64": [
+                {
+                    "metric": 2,
+                }
+            ],
+        }
+        return topotest.json_cmp(output, expected)
+
+    test_func = functools.partial(_show_routes, 2)
+    _, result = topotest.run_and_expect(test_func, None, count=30, wait=1)
+    assert result is None, "No aggregate address received"
+
+    # Turn it off
+    r3.vtysh_cmd("conf\nrouter ripng\nno aggregate-address 33::/64")
+
+    def _show_routes_removed(nh_num):
+        output = json.loads(r2.vtysh_cmd("show ipv6 route ripng json"))
+        expected = {
+            "33::1/128": [
+                {
+                    "metric": 2,
+                }
+            ],
+            "33::2/128": [
+                {
+                    "metric": 2,
+                }
+            ],
+            "33::3/128": [
+                {
+                    "metric": 2,
+                }
+            ],
+            "33::4/128": [
+                {
+                    "metric": 2,
+                }
+            ],
+        }
+        return topotest.json_cmp(output, expected)
+
+    test_func = functools.partial(_show_routes_removed, 2)
+    _, result = topotest.run_and_expect(test_func, None, count=30, wait=1)
+    assert result is None, "Non aggregate routes are not present"
+
+
+if __name__ == "__main__":
+    args = ["-s"] + sys.argv[1:]
+    sys.exit(pytest.main(args))