From: Renato Westphal <renato@opensourcerouting.org>
Date: Mon, 19 Dec 2016 16:07:28 +0000 (-0200)
Subject: ldpd: add missing privilege dropping on error path
X-Git-Tag: frr-3.0-branchpoint~94^2~2^2~3
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=07bc3833841ec104b10f48d936da18aaf6ddcf29;p=matthieu%2Ffrr.git

ldpd: add missing privilege dropping on error path

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
---

diff --git a/ldpd/socket.c b/ldpd/socket.c
index 1bb0837401..eaea9973a0 100644
--- a/ldpd/socket.c
+++ b/ldpd/socket.c
@@ -85,6 +85,8 @@ ldp_create_socket(int af, enum socket_type type)
 	if (ldpd_privs.change(ZPRIVS_RAISE))
 		log_warn("%s: could not raise privs", __func__);
 	if (sock_set_reuse(fd, 1) == -1) {
+		if (ldpd_privs.change(ZPRIVS_LOWER))
+			log_warn("%s: could not lower privs", __func__);
 		close(fd);
 		return (-1);
 	}