From: anlan_cs <vic.lan@pica8.com>
Date: Sun, 16 Apr 2023 05:41:40 +0000 (+0800)
Subject: bgpd: Remove unnecessary check for groups
X-Git-Tag: base_9.0~168^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=06af0667add9accffd615d73cabe45c5884ff4c3;p=mirror%2Ffrr.git

bgpd: Remove unnecessary check for groups

The `NULL` check for newly created groups (`updgroup` and `subgroup`)
are unnecessary,  just remove them.

Signed-off-by: anlan_cs <vic.lan@pica8.com>
---

diff --git a/bgpd/bgp_updgrp.c b/bgpd/bgp_updgrp.c
index 72dca9f702..0b1e54916a 100644
--- a/bgpd/bgp_updgrp.c
+++ b/bgpd/bgp_updgrp.c
@@ -1961,15 +1961,8 @@ void update_group_adjust_peer(struct peer_af *paf)
 	}
 
 	updgrp = update_group_find(paf);
-	if (!updgrp) {
+	if (!updgrp)
 		updgrp = update_group_create(paf);
-		if (!updgrp) {
-			flog_err(EC_BGP_UPDGRP_CREATE,
-				 "couldn't create update group for peer %s",
-				 paf->peer->host);
-			return;
-		}
-	}
 
 	old_subgrp = paf->subgroup;
 
@@ -1992,11 +1985,8 @@ void update_group_adjust_peer(struct peer_af *paf)
 	}
 
 	subgrp = update_subgroup_find(updgrp, paf);
-	if (!subgrp) {
+	if (!subgrp)
 		subgrp = update_subgroup_create(updgrp);
-		if (!subgrp)
-			return;
-	}
 
 	update_subgroup_add_peer(subgrp, paf, 1);
 	if (BGP_DEBUG(update_groups, UPDATE_GROUPS))