From: Donatas Abraitis <donatas@opensourcerouting.org>
Date: Thu, 27 Mar 2025 11:35:39 +0000 (+0200)
Subject: Revert "staticd: Fix crash that occurs when modifying an SRv6 SID"
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=0436ef828e3c18b01b5b2a67ed5a7cfa9f0ef7a1;p=matthieu%2Ffrr.git

Revert "staticd: Fix crash that occurs when modifying an SRv6 SID"

This reverts commit c80c2b2a4226640464a38f8ee9f8b2b4be8bd094.
---

diff --git a/staticd/static_nb_config.c b/staticd/static_nb_config.c
index 0267f7c3ae..e2ab1f2ffe 100644
--- a/staticd/static_nb_config.c
+++ b/staticd/static_nb_config.c
@@ -1112,7 +1112,6 @@ int routing_control_plane_protocols_control_plane_protocol_staticd_segment_routi
 	yang_dnode_get_ipv6p(&sid_value, args->dnode, "sid");
 	sid = static_srv6_sid_alloc(&sid_value);
 	nb_running_set_entry(args->dnode, sid);
-	listnode_add(srv6_sids, sid);
 
 	return NB_OK;
 }
@@ -1146,11 +1145,13 @@ void routing_control_plane_protocols_control_plane_protocol_staticd_segment_rout
 		       "%s: Locator %s not found, trying to get locator information from zebra",
 		       __func__, sid->locator_name);
 		static_zebra_srv6_manager_get_locator(sid->locator_name);
+		listnode_add(srv6_sids, sid);
 		return;
 	}
 
 	sid->locator = locator;
 
+	listnode_add(srv6_sids, sid);
 	static_zebra_request_srv6_sid(sid);
 }