From: Donatas Abraitis <donatas@opensourcerouting.org>
Date: Tue, 16 Jan 2024 13:29:32 +0000 (+0200)
Subject: bgpd: Send notification if AS4 capability failed to parse (malformed)
X-Git-Tag: base_10.0~110^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=02a5da440b40efa3fd80eb60f81997250f98c561;p=matthieu%2Ffrr.git

bgpd: Send notification if AS4 capability failed to parse (malformed)

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
---

diff --git a/bgpd/bgp_open.c b/bgpd/bgp_open.c
index ac7fbc215b..154efdedaf 100644
--- a/bgpd/bgp_open.c
+++ b/bgpd/bgp_open.c
@@ -626,7 +626,7 @@ static as_t bgp_capability_as4(struct peer *peer, struct capability_header *hdr)
 		flog_err(EC_BGP_PKT_OPEN,
 			 "%s AS4 capability has incorrect data length %d",
 			 peer->host, hdr->length);
-		return 0;
+		return -1;
 	}
 
 	as_t as4 = stream_getl(BGP_INPUT(peer));