]> git.puffer.fish Git - mirror/frr.git/commitdiff
tests: Close some open handles 7679/head
authorDonald Sharp <sharpd@nvidia.com>
Sun, 6 Dec 2020 01:05:52 +0000 (20:05 -0500)
committerDonald Sharp <sharpd@nvidia.com>
Sun, 6 Dec 2020 01:05:52 +0000 (20:05 -0500)
I accidently installed something that is telling me about
unlosed handles in the tests.  Let's clean them up.

<and yes I have no idea wtf I did>

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
tests/topotests/lib/topogen.py

index 7ae4223f72d803d1910a178256cb2c394e39802c..eaf7f90479e403847e6bd0b42154a0df2e403c85 100644 (file)
@@ -1114,6 +1114,7 @@ def diagnose_env_linux():
             logger.warning(
                 "BGP topologies are still using exabgp version 3, expect failures"
             )
+        p.close()
 
     # We want to catch all exceptions
     # pylint: disable=W0702
@@ -1122,6 +1123,7 @@ def diagnose_env_linux():
 
     # After we logged the output to file, remove the handler.
     logger.removeHandler(fhandler)
+    fhandler.close()
 
     return ret