]> git.puffer.fish Git - mirror/frr.git/commitdiff
zebra: Don't do expensive string manip if not in debug 7413/head
authorDonald Sharp <sharpd@nvidia.com>
Mon, 26 Oct 2020 13:19:18 +0000 (09:19 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Thu, 29 Oct 2020 13:00:43 +0000 (09:00 -0400)
Modify the code to not load up a string that is only used
in debugging unless we are debugging.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
zebra/zebra_rib.c

index 08daddb16408efb0065218704984a36442abbe7d..093e1c4095117ff56dc9e4685309fc97a21f35d4 100644 (file)
@@ -3083,16 +3083,15 @@ void rib_delete(afi_t afi, safi_t safi, vrf_id_t vrf_id, int type,
        /* Lookup route node. */
        rn = srcdest_rnode_lookup(table, p, src_p);
        if (!rn) {
-               char src_buf[PREFIX_STRLEN];
-
-               if (src_p && src_p->prefixlen)
-                       prefix2str(src_p, src_buf, sizeof(src_buf));
-               else
-                       src_buf[0] = '\0';
-
                if (IS_ZEBRA_DEBUG_RIB) {
+                       char src_buf[PREFIX_STRLEN];
                        struct vrf *vrf = vrf_lookup_by_id(vrf_id);
 
+                       if (src_p && src_p->prefixlen)
+                               prefix2str(src_p, src_buf, sizeof(src_buf));
+                       else
+                               src_buf[0] = '\0';
+
                        zlog_debug("%s[%d]:%pFX%s%s doesn't exist in rib",
                                   vrf->name, table_id, p,
                                   (src_buf[0] != '\0') ? " from " : "",