]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: Bypass SA tests regarding division by zero for reuse_limit in dampening 6808/head
authorDonatas Abraitis <donatas.abraitis@gmail.com>
Mon, 27 Jul 2020 17:38:42 +0000 (20:38 +0300)
committerDonatas Abraitis <donatas.abraitis@gmail.com>
Mon, 27 Jul 2020 17:38:42 +0000 (20:38 +0300)
reuse_limit can't be zero basically, Coverity just does not know how the
value comes in.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd/bgp_damp.c

index 97d625493fc6a6643773d65df62fd8ce4162bc2d..565d0b8e19db47b5cf9aaed2429e5a32b81fb070 100644 (file)
@@ -50,6 +50,12 @@ static int bgp_reuse_index(int penalty, struct bgp_damp_config *bdc)
        unsigned int i;
        int index;
 
+       /*
+        * reuse_limit can't be zero, this is for Coverity
+        * to bypass division by zero test.
+        */
+       assert(bdc->reuse_limit);
+
        i = (int)(((double)penalty / bdc->reuse_limit - 1.0)
                  * bdc->scale_factor);