]> git.puffer.fish Git - mirror/frr.git/commitdiff
staticd: Make blackhole keyword errors more straightforward 5303/head
authorTrey Aspelund <taspelund@cumulusnetworks.com>
Fri, 8 Nov 2019 21:51:36 +0000 (16:51 -0500)
committerTrey Aspelund <taspelund@cumulusnetworks.com>
Thu, 14 Nov 2019 22:39:02 +0000 (17:39 -0500)
Previous error was misleading and made it seem like Null0,
reject, or blackhole nexthops on static routes are invalid.
This commit makes it more clear as to why the error is seen.

Signed-off-by: Trey Aspelund <taspelund@cumulusnetworks.com>
staticd/static_vty.c

index 8cc4ccced1e22383a8da402e3a71e08f8032c86c..48ad10e90cbabcea6bc401920094f26a0f73efe0 100644 (file)
@@ -431,10 +431,10 @@ static int static_route_leak(
                    || strcasecmp(ifname, "blackhole") == 0) {
                        if (vty)
                                vty_out(vty,
-                                       "%% Nexthop interface cannot be Null0, reject or blackhole\n");
+                                       "%% Nexthop interface name can not be from reserved keywords (Null0, reject, blackhole)\n");
                        else
                                zlog_warn(
-                                       "%s: Nexthop interface cannot be Null0, reject or blackhole for %s",
+                                       "%s: %s: Nexthop interface name can not be from reserved keywords (Null0, reject, blackhole)\n",
                                        __PRETTY_FUNCTION__, dest_str);
                        return CMD_WARNING_CONFIG_FAILED;
                }