isisd: Remove unnecessary use of strcpy

`strcpy` is a dangerous function and should not be used. In this
particular place, there is no need for copying strings at all, so let's
just stick to referencing static strings.

Signed-off-by: Christian Franke <chris@opensourcerouting.org>

diff --git a/isisd/isisd.c b/isisd/isisd.c
index 0b7d44ea1c1a3d248e6c2e604d03430e5ade2c11..bee3b6deb56e5dbb401c75c6f3d525fbf5ab6850 100644 (file)
--- a/isisd/isisd.c
+++ b/isisd/isisd.c
@@ -738,11 +738,7 @@ DEFUN (clear_isis_neighbor_arg,
  */
 void print_debug(struct vty *vty, int flags, int onoff)
 {
-       char onoffs[4];
-       if (onoff)
-               strcpy(onoffs, "on");
-       else
-               strcpy(onoffs, "off");
+       const char *onoffs = onoff ? "on" : "off";
 
        if (flags & DEBUG_ADJ_PACKETS)
                vty_out(vty,