]> git.puffer.fish Git - mirror/frr.git/commitdiff
pimd: strncpy -> strlcpy 3877/head
authorQuentin Young <qlyoung@cumulusnetworks.com>
Tue, 26 Feb 2019 20:35:29 +0000 (20:35 +0000)
committerQuentin Young <qlyoung@cumulusnetworks.com>
Tue, 26 Feb 2019 20:50:17 +0000 (20:50 +0000)
strncpy is a byte copy function not a string copy function

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
pimd/pim_register.c

index b9908ae22be4ea5bbabee4b65f08624c170b82e1..4b402de6348e10f651b396ac3b2dd7fd9b2d3f5c 100644 (file)
@@ -189,8 +189,8 @@ void pim_register_send(const uint8_t *buf, int buf_size, struct in_addr src,
 
        if (PIM_DEBUG_PIM_REG) {
                char rp_str[INET_ADDRSTRLEN];
-               strncpy(rp_str, inet_ntoa(rpg->rpf_addr.u.prefix4),
-                       INET_ADDRSTRLEN - 1);
+               strlcpy(rp_str, inet_ntoa(rpg->rpf_addr.u.prefix4),
+                       sizeof(rp_str));
                zlog_debug("%s: Sending %s %sRegister Packet to %s on %s",
                           __PRETTY_FUNCTION__, up->sg_str,
                           null_register ? "NULL " : "", rp_str, ifp->name);