]> git.puffer.fish Git - mirror/frr.git/commitdiff
lib: out-of-bounds access (Coverity 1452539) 2463/head
authorpaco <paco@voltanet.io>
Fri, 15 Jun 2018 14:54:09 +0000 (16:54 +0200)
committerpaco <paco@voltanet.io>
Thu, 21 Jun 2018 22:06:07 +0000 (00:06 +0200)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib/sbuf.c

index 37c1e5283deac6ed38a7114ca94cbfa5e7cf3a7a..03a2be3e09fa39dc0ea6ac9405b679a64f422afc 100644 (file)
@@ -63,13 +63,12 @@ void sbuf_push(struct sbuf *buf, int indent, const char *format, ...)
        int written;
 
        if (!buf->fixed) {
-               char dummy;
                int written1, written2;
                size_t new_size;
 
-               written1 = snprintf(&dummy, 0, "%*s", indent, "");
+               written1 = indent;
                va_start(args, format);
-               written2 = vsnprintf(&dummy, 0, format, args);
+               written2 = vsnprintf(NULL, 0, format, args);
                va_end(args);
 
                new_size = buf->size;