]> git.puffer.fish Git - mirror/frr.git/commitdiff
ospfd: buffer termination (Coverity 1464993) 2435/head
authorpaco <paco@voltanet.io>
Wed, 13 Jun 2018 15:24:51 +0000 (17:24 +0200)
committerpaco <paco@voltanet.io>
Thu, 14 Jun 2018 14:59:31 +0000 (16:59 +0200)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospfd/ospf_ext.c

index ac5df3eb4e2d1779ca6af55d02c6f64693d7298d..331cba44a8e446778805f43c2cee710bbc139bb1 100644 (file)
@@ -1125,7 +1125,7 @@ static int ospf_ext_pref_lsa_originate1(struct ospf_area *area,
        if (IS_DEBUG_OSPF(lsa, LSA_GENERATE)) {
                char area_id[INET_ADDRSTRLEN];
 
-               strncpy(area_id, inet_ntoa(area->area_id), INET_ADDRSTRLEN);
+               inet_ntop(AF_INET, &area->area_id, area_id, sizeof(area_id));
                zlog_debug(
                        "EXT (%s): LSA[Type%u:%s]: Originate Opaque-LSA "
                        "Extended Prefix Opaque LSA: Area(%s), Link(%s)",
@@ -1175,7 +1175,7 @@ static int ospf_ext_link_lsa_originate1(struct ospf_area *area,
        if (IS_DEBUG_OSPF(lsa, LSA_GENERATE)) {
                char area_id[INET_ADDRSTRLEN];
 
-               strncpy(area_id, inet_ntoa(area->area_id), INET_ADDRSTRLEN);
+               inet_ntop(AF_INET, &area->area_id, area_id, sizeof(area_id));
                zlog_debug(
                        "EXT (%s): LSA[Type%u:%s]: Originate Opaque-LSA "
                        "Extended Link Opaque LSA: Area(%s), Link(%s)",