vtysh: fix SA warning, no need to call getenv() twice

Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>

diff --git a/vtysh/vtysh_main.c b/vtysh/vtysh_main.c
index 64198132cc640902a13e0d7e4f68d257d63af088..297d87ec419d495d5729d16dd774991685b985c0 100644 (file)
--- a/vtysh/vtysh_main.c
+++ b/vtysh/vtysh_main.c
@@ -350,6 +350,7 @@ int main(int argc, char **argv, char **env)
        char pathspace[MAXPATHLEN] = "";
        const char *histfile = NULL;
        const char *histfile_env = getenv("VTYSH_HISTFILE");
+       const char *logpath = getenv("VTYSH_LOG");
 
        /* SUID: drop down to calling user & go back up when needed */
        elevuid = geteuid();
@@ -643,9 +644,7 @@ int main(int argc, char **argv, char **env)
                }
        }
 
-       if (getenv("VTYSH_LOG")) {
-               const char *logpath = getenv("VTYSH_LOG");
-
+       if (logpath != NULL) {
                logfile = fopen(logpath, "a");
                if (!logfile) {
                        fprintf(stderr, "Failed to open logfile (%s): %s\n",