]> git.puffer.fish Git - mirror/frr.git/commitdiff
mgmtd: Ensure map is NULL 16677/head
authorDonald Sharp <sharpd@nvidia.com>
Wed, 28 Aug 2024 14:09:52 +0000 (10:09 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Wed, 28 Aug 2024 14:09:52 +0000 (10:09 -0400)
Build is complaining:
build 27-Aug-2024 05:46:38 mgmtd/mgmt_be_adapter.c: In function ‘mgmt_register_client_xpath’:
build 27-Aug-2024 05:46:38 mgmtd/mgmt_be_adapter.c:274:27: warning: ‘maps’ may be used uninitialized [-Wmaybe-uninitialized]
build 27-Aug-2024 05:46:38   274 |         map = darr_append(*maps);
build 27-Aug-2024 05:46:38       |                           ^
build 27-Aug-2024 05:46:38 mgmtd/mgmt_be_adapter.c:250:36: note: ‘maps’ was declared here
build 27-Aug-2024 05:46:38   250 |         struct mgmt_be_xpath_map **maps, *map;
build 27-Aug-2024 05:46:38       |                                    ^~~~

Let's make the compiler happy, even though there is no problem.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
mgmtd/mgmt_be_adapter.c

index f1c5424d0a1ef6289280ac749adb4dbb9f3983ba..93c9bcac44c1f7383f8f695cb7db6f63e9013161 100644 (file)
@@ -249,6 +249,8 @@ static void mgmt_register_client_xpath(enum mgmt_be_client_id id,
 {
        struct mgmt_be_xpath_map **maps, *map;
 
+       maps = NULL;
+
        switch (type) {
        case MGMT_BE_XPATH_SUBSCR_TYPE_CFG:
                maps = &be_cfg_xpath_map;