]> git.puffer.fish Git - mirror/frr.git/commitdiff
pimd: fix possible NULL dereference 16509/head
authorRafael Zalamena <rzalamena@opensourcerouting.org>
Wed, 31 Jul 2024 13:18:47 +0000 (10:18 -0300)
committerRafael Zalamena <rzalamena@opensourcerouting.org>
Wed, 31 Jul 2024 13:18:47 +0000 (10:18 -0300)
Coverity scan ID: 1598684

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
pimd/pim_cmd.c

index dcfad2a4f81ad5ae6f7b76fa046ed282815d52a3..f57048c7037fc3f2bd37d341d2fba4bfe819849e 100644 (file)
@@ -2837,13 +2837,14 @@ DEFPY(clear_ip_msdp_peer, clear_ip_msdp_peer_cmd,
        const struct vrf *vrf;
        struct pim_msdp_peer *mp;
 
-       if (vrfname) {
+       if (vrfname)
                vrf = vrf_lookup_by_name(vrfname);
-               if (vrf == NULL)
-                       return CMD_WARNING;
-       } else
+       else
                vrf = vrf_lookup_by_id(VRF_DEFAULT);
 
+       if (vrf == NULL || vrf->info == NULL)
+               return CMD_WARNING;
+
        pim = vrf->info;
        for (ALL_LIST_ELEMENTS_RO(pim->msdp.peer_list, node, mp)) {
                if (mp->peer.s_addr != peer.s_addr)