bgpd: Do not increment treat-as-withdraw counters if debug is enabled

Increment only if we really treat the UPDATE as withdrawn.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c
index 0fb59a94c28310cf20ebdec42edd45bd0e0f7a0e..842fd1734ad390f17f61f568829ed19c91b27939 100644 (file)
--- a/bgpd/bgp_packet.c
+++ b/bgpd/bgp_packet.c
@@ -2390,13 +2390,13 @@ static int bgp_update_receive(struct peer_connection *connection,
                ret = bgp_dump_attr(&attr, peer->rcvd_attr_str,
                                    sizeof(peer->rcvd_attr_str));
 
-               peer->stat_upd_7606++;
-
-               if (attr_parse_ret == BGP_ATTR_PARSE_WITHDRAW)
+               if (attr_parse_ret == BGP_ATTR_PARSE_WITHDRAW) {
+                       peer->stat_upd_7606++;
                        flog_err(
                                EC_BGP_UPDATE_RCV,
                                "%pBP rcvd UPDATE with errors in attr(s)!! Withdrawing route.",
                                peer);
+               }
 
                if (ret && bgp_debug_update(peer, NULL, NULL, 1) &&
                    BGP_DEBUG(update, UPDATE_DETAIL)) {