]> git.puffer.fish Git - mirror/frr.git/commitdiff
babeld: ignore nonzero flag bits in Hello TLVs 13358/head
authorzmw12306 <zmw12306@gmail.com>
Sat, 22 Apr 2023 19:11:13 +0000 (15:11 -0400)
committerzmw12306 <zmw12306@gmail.com>
Sat, 22 Apr 2023 19:11:13 +0000 (15:11 -0400)
Ignore all other bits(except U) in Hello TLVs, according to RFC8966
Signed-off-by: zmw12306 <zmw12306@gmail.com>
babeld/message.c

index b5c2a589848f97eab66d45686d6d50fc668f9062..15d772eb46d860cdd862a1d29a8d9e77675b3b3e 100644 (file)
@@ -413,18 +413,6 @@ parse_packet(const unsigned char *from, struct interface *ifp,
 #define BABEL_UNICAST_HELLO 0x8000
                DO_NTOHS(flags, message + 2);
 
-               /*
-                * RFC 8966 4.6.5
-                * All other bits MUST be sent as a 0 and silently
-                * ignored on reception
-                */
-               if (CHECK_FLAG(flags, ~BABEL_UNICAST_HELLO)) {
-                       debugf(BABEL_DEBUG_COMMON,
-                              "Received Hello from %s on %s that does not have all 0's in the unused section of flags, ignoring",
-                              format_address(from), ifp->name);
-                       goto done;
-               }
-
                /*
                 * RFC 8966 Appendix F
                 * TL;DR -> Please ignore Unicast hellos until FRR's