lib: Remove unnecessary comparison, for linked list

In the comparison function for a linked list code was
always checking against passed in NULL's.  The comparison
function will never receive a NULL value for data from
the linklist.c code.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
(cherry picked from commit 78946603e10489969bad3b364a96ca01d436b47d)

diff --git a/lib/routemap.c b/lib/routemap.c
index 3cc010c148d454cdf4147367d4acb69a33b75b0d..2b3347820746bbf036fa628eb39dd15c3ee31c83 100644 (file)
--- a/lib/routemap.c
+++ b/lib/routemap.c
@@ -1890,12 +1890,7 @@ route_map_get_index(struct route_map *map, const struct prefix *prefix,
 static int route_map_candidate_list_cmp(struct route_map_index *idx1,
                                        struct route_map_index *idx2)
 {
-       if (!idx1)
-               return -1;
-       if (!idx2)
-               return 1;
-
-       return (idx1->pref - idx2->pref);
+       return idx1->pref - idx2->pref;
 }
 
 /*