]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: Pass struct pfx_record to sizeof 10475/head
authorDonatas Abraitis <donatas.abraitis@gmail.com>
Wed, 2 Feb 2022 11:30:52 +0000 (13:30 +0200)
committerDonatas Abraitis <donatas.abraitis@gmail.com>
Wed, 2 Feb 2022 14:18:43 +0000 (16:18 +0200)
Passing argument "&rec" of type "struct pfx_record *" and argument
"1UL" to function "read" is suspicious because
"sizeof (struct pfx_record) /*40*/" is expected.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd/bgp_rpki.c

index e5027359e71a56feb0dfff31deea4afee1c8460a..b320e4e719d179819e60adfb5e196ec49d4f882a 100644 (file)
@@ -369,7 +369,7 @@ static int bgpd_sync_callback(struct thread *thread)
        thread_add_read(bm->master, bgpd_sync_callback, NULL, socket, &t_rpki);
 
        if (atomic_load_explicit(&rtr_update_overflow, memory_order_seq_cst)) {
-               while (read(socket, &rec, sizeof(rec) != -1))
+               while (read(socket, &rec, sizeof(struct pfx_record) != -1))
                        ;
 
                atomic_store_explicit(&rtr_update_overflow, 0,
@@ -378,8 +378,8 @@ static int bgpd_sync_callback(struct thread *thread)
                return 0;
        }
 
-       retval = read(socket, &rec, sizeof(rec));
-       if (retval != sizeof(rec)) {
+       retval = read(socket, &rec, sizeof(struct pfx_record));
+       if (retval != sizeof(struct pfx_record)) {
                RPKI_DEBUG("Could not read from socket");
                return retval;
        }