bfdd: fix coverity warnings

show/clear DEFUNs always require either peer label or IP address to be
specified, so if `label` is NULL then `peer_str` is definitely not NULL.
But Coverity doesn't know about that, so it complains about possible
NULL dereference of `peer_str`. This commit should make Coverity happy.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

diff --git a/bfdd/bfdd_vty.c b/bfdd/bfdd_vty.c
index a03fb9f216534a32d13f91cadd133fbf15b07127..4091ab9caae736c616cdde36067383a77290b223 100644 (file)
--- a/bfdd/bfdd_vty.c
+++ b/bfdd/bfdd_vty.c
@@ -579,7 +579,7 @@ _find_peer_or_error(struct vty *vty, int argc, struct cmd_token **argv,
                pl = pl_find(label);
                if (pl)
                        bs = pl->pl_bs;
-       } else {
+       } else if (peer_str) {
                strtosa(peer_str, &psa);
                if (local_str) {
                        strtosa(local_str, &lsa);
@@ -599,6 +599,9 @@ _find_peer_or_error(struct vty *vty, int argc, struct cmd_token **argv,
                }
 
                bs = bs_peer_find(&bpc);
+       } else {
+               vty_out(vty, "%% Invalid arguments\n");
+               return NULL;
        }
 
        /* Find peer data. */