lib: Convert to flog_warn in agentx.c

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

diff --git a/lib/agentx.c b/lib/agentx.c
index 8e6493d4d37c273896648ddd88532c53824a9288..e4d35854fa0423c7344721b0c9fc208cf5ea12c9 100644 (file)
--- a/lib/agentx.c
+++ b/lib/agentx.c
@@ -158,7 +158,8 @@ static int agentx_log_callback(int major, int minor, void *serverarg,
                          "snmp[err]: %s", msg ? msg : slm->msg);
                break;
        case LOG_WARNING:
-               zlog_warn("snmp[warning]: %s", msg ? msg : slm->msg);
+               flog_warn(LIB_WARN_SNMP,
+                         "snmp[warning]: %s", msg ? msg : slm->msg);
                break;
        case LOG_NOTICE:
                zlog_notice("snmp[notice]: %s", msg ? msg : slm->msg);

diff --git a/lib/lib_errors.c b/lib/lib_errors.c
index 332a5b1d453aac833f4811dd1734a177b9f1a98c..cf23c9c6dd14a6765988f3cb703f666c99188635 100644 (file)
--- a/lib/lib_errors.c
+++ b/lib/lib_errors.c
@@ -21,6 +21,18 @@
 #include "lib_errors.h"
 
 /* clang-format off */
+static struct log_ref ferr_lib_warn[] = {
+       {
+               .code = LIB_WARN_SNMP,
+               .title = "SNMP has discovered a warning",
+               .description = "The SNMP AgentX library has returned a warning that we should report to the end user",
+               .suggestion = "Gather Log data and open an Issue.",
+       },
+       {
+               .code = END_FERR,
+       },
+};
+
 static struct log_ref ferr_lib_err[] = {
        {
                .code = LIB_ERR_PRIVILEGES,
@@ -114,5 +126,6 @@ static struct log_ref ferr_lib_err[] = {
 
 void lib_error_init(void)
 {
+       log_ref_add(ferr_lib_warn);
        log_ref_add(ferr_lib_err);
 }

diff --git a/lib/lib_errors.h b/lib/lib_errors.h
index 84f5b8dc1091c8a527b5218343183c37ad093956..9c9f51fe0e03c0b5627d062ef038e5e957f49258 100644 (file)
--- a/lib/lib_errors.h
+++ b/lib/lib_errors.h
@@ -38,6 +38,7 @@ enum lib_log_refs {
        LIB_ERR_DEVELOPMENT,
        LIB_ERR_ZMQ,
        LIB_ERR_UNAVAILABLE,
+       LIB_WARN_SNMP,
 };
 
 extern void lib_error_init(void);