]> git.puffer.fish Git - mirror/frr.git/commitdiff
vrrpd: remove ifindex from hash key computation
authorQuentin Young <qlyoung@cumulusnetworks.com>
Wed, 13 Feb 2019 19:54:03 +0000 (19:54 +0000)
committerQuentin Young <qlyoung@cumulusnetworks.com>
Fri, 17 May 2019 00:27:08 +0000 (00:27 +0000)
Ifindexes apparently change more often than one might expect and so are
not suitable for use in hash keys.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
vrrpd/vrrp.c

index b773bdf870af44b2d660202b03539dc2cd121d25..92caaeff3b83634f7b7e0177049d70aae2809c70 100644 (file)
@@ -1614,8 +1614,7 @@ static unsigned int vrrp_hash_key(void *arg)
        struct vrrp_vrouter *vr = arg;
 
        char key[IFNAMSIZ + 64];
-       snprintf(key, sizeof(key), "%d%s%u", vr->ifp->ifindex, vr->ifp->name,
-                vr->vrid);
+       snprintf(key, sizeof(key), "%s@%" PRIu8, vr->ifp->name, vr->vrid);
 
        return string_hash_make(key);
 }