]> git.puffer.fish Git - mirror/frr.git/commitdiff
zebra: SO_PEERCRED is a getsockopt call
authorDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 9 Oct 2019 17:50:42 +0000 (13:50 -0400)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Fri, 6 Mar 2020 21:03:52 +0000 (16:03 -0500)
This code is effectively dead code.  SO_PEERCRED is a getsockopt
call not *setsockopt* call.  Additionally we are not doing
anything with the failed setsockopt call at all.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
zebra/zebra_mlag_private.c

index 83d0d44097dc2e985e0ae3ecdabb6722a4218c77..0f0285ed31ee297a61eec98588f6d5adc4f15484 100644 (file)
@@ -159,8 +159,6 @@ static int zebra_mlag_read(struct thread *thread)
 static int zebra_mlag_connect(struct thread *thread)
 {
        struct sockaddr_un svr = {0};
-       struct ucred ucred;
-       socklen_t len = 0;
 
        /* Reset the Timer-running flag */
        zrouter.mlag_info.timer_running = false;
@@ -184,11 +182,8 @@ static int zebra_mlag_connect(struct thread *thread)
                                 &zrouter.mlag_info.t_read);
                return 0;
        }
-       len = sizeof(struct ucred);
-       ucred.pid = getpid();
 
        set_nonblocking(mlag_socket);
-       setsockopt(mlag_socket, SOL_SOCKET, SO_PEERCRED, &ucred, len);
 
        if (IS_ZEBRA_DEBUG_MLAG)
                zlog_debug("%s: Connection with MLAG is established ",