]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: honor max prefix timer on inbound sessions
authorMatthew Smith <mgsmith@netgate.com>
Tue, 9 Jul 2019 17:59:44 +0000 (12:59 -0500)
committerDonatas Abraitis <donatas.abraitis@gmail.com>
Wed, 16 Oct 2019 05:29:10 +0000 (08:29 +0300)
When using the maximum-prefix restart option with a BGP peer,
if the peer exceeds the limit of prefixes, bgpd causes the
connection to be closed and sets a timer. It will not attempt
to connect to that peer until the timer expires. But if the
peer attempts to connect to it before the timer expires, it
accepts the connection and starts exchanging routes again.

When accepting a connection from a peer, reject the connection
if the max prefix restart timer is set.

Signed-off-by: Matthew Smith <mgsmith@netgate.com>
bgpd/bgp_network.c

index 4153da5a644144f5ba90f44c399ac03b83c57aff..f76ae4290fd3bf3bd506d288b563ae438025917e 100644 (file)
@@ -382,6 +382,17 @@ static int bgp_accept(struct thread *thread)
                return -1;
        }
 
+       /* Check whether max prefix restart timer is set for the peer */
+       if (peer1->t_pmax_restart) {
+               if (bgp_debug_neighbor_events(peer1))
+                       zlog_debug(
+                               "%s - incoming conn rejected - "
+                               "peer max prefix timer is active",
+                               peer1->host);
+               close(bgp_sock);
+               return -1;
+       }
+
        if (bgp_debug_neighbor_events(peer1))
                zlog_debug("[Event] BGP connection from host %s fd %d",
                           inet_sutop(&su, buf), bgp_sock);