]> git.puffer.fish Git - matthieu/frr.git/commitdiff
lib: work around enum issue in old gcc
authorQuentin Young <qlyoung@cumulusnetworks.com>
Tue, 24 Mar 2020 17:16:06 +0000 (13:16 -0400)
committerQuentin Young <qlyoung@cumulusnetworks.com>
Mon, 13 Apr 2020 21:03:42 +0000 (17:03 -0400)
I'd like to keep the explicit check here, but since underlying type of
enum is implementation defined, theres some inconsistency using -Wall
-Werror in older compilers here

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
lib/vrf.c

index 14f965ac8512975ce0d7eb802b52d1238eb2e879..e2afa2b231f32e3ed3c8d926c5e26312a85d3ba3 100644 (file)
--- a/lib/vrf.c
+++ b/lib/vrf.c
@@ -595,8 +595,15 @@ int vrf_get_backend(void)
 
 int vrf_configure_backend(enum vrf_backend_type backend)
 {
-       if (backend < 0 || backend >= VRF_BACKEND_MAX)
+       /* Work around issue in old gcc */
+       switch (backend) {
+       case VRF_BACKEND_UNKNOWN:
+       case VRF_BACKEND_NETNS:
+       case VRF_BACKEND_VRF_LITE:
+               break;
+       default:
                return -1;
+       }
 
        vrf_backend = backend;
        vrf_backend_configured = 1;