]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: remove extra ecom attr ptr increment
authorQuentin Young <qlyoung@cumulusnetworks.com>
Fri, 22 Nov 2019 00:00:11 +0000 (19:00 -0500)
committerQuentin Young <qlyoung@cumulusnetworks.com>
Thu, 16 Jan 2020 19:36:52 +0000 (14:36 -0500)
Copy paste leads to invalid read of 1 byte off the heap when converting
extended community attributes into strings.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
bgpd/bgp_ecommunity.c

index 850b85aa6a5bd8591badf83adce5a1d6ad7d406b..0b96748c38ac8faa183f60f2f9d472fb63e90e74 100644 (file)
@@ -822,7 +822,6 @@ char *ecommunity_ecom2str(struct ecommunity *ecom, int format, int filter)
                                   == ECOMMUNITY_EVPN_SUBTYPE_ES_IMPORT_RT) {
                                struct ethaddr mac;
 
-                               pnt++;
                                memcpy(&mac, pnt, ETH_ALEN);
                                len = sprintf(
                                        str_buf + str_pnt,