Denis Ovsienko <zebra@pilot.org.ua>

Subject: [zebra 18767] possible SIGSEGV

Fix incorrect memset

diff --git a/ospfd/ospf_interface.c b/ospfd/ospf_interface.c
index 270b16b97c1b036e2eacab8cd13e874f2fdd7b5a..c37e194858367c2c6730554255f864e1f50edf18 100644 (file)
--- a/ospfd/ospf_interface.c
+++ b/ospfd/ospf_interface.c
@@ -467,11 +467,12 @@ ospf_new_if_params ()
   struct ospf_if_params *oip;
 
   oip = XMALLOC (MTYPE_OSPF_IF_PARAMS, sizeof (struct ospf_if_params));
-  memset (oip, 0, sizeof (struct ospf_if_params));
 
   if (!oip)
     return NULL;
 
+  memset (oip, 0, sizeof (struct ospf_if_params));
+
   UNSET_IF_PARAM (oip, output_cost_cmd);
   UNSET_IF_PARAM (oip, transmit_delay);
   UNSET_IF_PARAM (oip, retransmit_interval);