]> git.puffer.fish Git - mirror/frr.git/commitdiff
bfdd: Fix `don't assign to value to ourself` compiler warning 2844/head
authorDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 15 Aug 2018 17:48:09 +0000 (13:48 -0400)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 15 Aug 2018 17:48:09 +0000 (13:48 -0400)
We were attempting to get around a unused value by setting
a variable to itself, but it runs afoul of a different
compiler and a message about not setting a variable to
itself.  So let's mark the ttl value as unused.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bfdd/ptm_adapter.c

index ca44be6541acb6d3958722c4ef1ce4a5e0d12d4c..9a2b70d36a64c7fa3b320c0d44f85b0f9b0dfa89 100644 (file)
@@ -286,7 +286,7 @@ static int _ptm_msg_read(struct stream *msg, int command,
                         struct bfd_peer_cfg *bpc, struct ptm_client **pc)
 {
        uint32_t pid;
-       uint8_t ttl;
+       uint8_t ttl __attribute__((unused));
        uint8_t ifnamelen;
 
        /*
@@ -360,12 +360,6 @@ static int _ptm_msg_read(struct stream *msg, int command,
                /* Read multihop source address and TTL. */
                _ptm_msg_read_address(msg, &bpc->bpc_local);
                STREAM_GETC(msg, ttl);
-
-               /*
-                * TODO: use TTL for something. The line below removes
-                * an unused variable compiler warning.
-                */
-               ttl = ttl;
        } else {
                /* If target is IPv6, then we must obtain local address. */
                if (bpc->bpc_ipv4 == false)