]> git.puffer.fish Git - matthieu/frr.git/commitdiff
ldpd: Clarify error situation for different problems
authorDonald Sharp <sharpd@nvidia.com>
Fri, 13 Oct 2023 11:17:17 +0000 (07:17 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Fri, 13 Oct 2023 17:48:43 +0000 (13:48 -0400)
Clarify the fatal error message recorded when an error situation
happens.  Disambiguating the default case from the TLV_TYPE_DYNAMIC_CAP
case.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
ldpd/init.c

index c34d18f8b2378dc81605f92d7a101b11500b2cc5..ef782471b8dbbe70bce6a7f1886d27ad13c5b784 100644 (file)
@@ -229,9 +229,11 @@ send_capability(struct nbr *nbr, uint16_t capability, int enable)
                 * Announcement Parameter in Capability messages sent to
                 * its peers".
                 */
-               fallthrough;
+               fatalx("send_capability: An LDP speaker MUST NOT include the Dynamic Capability Announcement Parameter");
+               break;
        default:
                fatalx("send_capability: unsupported capability");
+               break;
        }
 
        if (err) {