]> git.puffer.fish Git - matthieu/frr.git/commitdiff
ospfd: Fix compile warning with `-Wformat-truncation`
authorDonatas Abraitis <donatas@opensourcerouting.org>
Sat, 13 Apr 2024 19:41:43 +0000 (22:41 +0300)
committerDonatas Abraitis <donatas@opensourcerouting.org>
Sat, 13 Apr 2024 19:41:43 +0000 (22:41 +0300)
ospfd/ospf_sr.c: In function ‘show_sr_node.part.5’:
ospfd/ospf_sr.c:2745:32: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 2 [-Wformat-truncation=]
    snprintf(tmp, sizeof(tmp), "%u", i);
                                ^~
ospfd/ospf_sr.c:2745:31: note: directive argument in the range [0, 2147483646]
    snprintf(tmp, sizeof(tmp), "%u", i);

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
ospfd/ospf_sr.c

index e26fe6f53a12087f65766adbe4610adba90424ad..198309c1eff8b89a6ab2cc1517fc8047788a4d8e 100644 (file)
@@ -2740,9 +2740,9 @@ static void show_sr_node(struct vty *vty, struct json_object *json,
                        if (srn->algo[i] == SR_ALGORITHM_UNSET)
                                continue;
                        json_obj = json_object_new_object();
-                       char tmp[2];
+                       char tmp[12];
 
-                       snprintf(tmp, sizeof(tmp), "%u", i);
+                       snprintf(tmp, sizeof(tmp), "%d", i);
                        json_object_string_add(json_obj, tmp,
                                               srn->algo[i] == SR_ALGORITHM_SPF
                                                       ? "SPF"