bgpd: avoid possible memleak

In the case of without ':' in `ecom_str`, memleak on this `ecom_str` will
occur. Just free `ecom_str` for this case.

Signed-off-by: anlan_cs <vic.lan@pica8.com>

diff --git a/bgpd/bgp_evpn_vty.c b/bgpd/bgp_evpn_vty.c
index c0ad72dc3389de27f9e895b48ebff539f6b135f9..7dbfdc60d45a68f70efe99f5e49faafe265c2171 100644 (file)
--- a/bgpd/bgp_evpn_vty.c
+++ b/bgpd/bgp_evpn_vty.c
@@ -6639,9 +6639,10 @@ void bgp_config_write_evpn_info(struct vty *vty, struct bgp *bgp, afi_t afi,
                                char *vni_str = NULL;
 
                                vni_str = strchr(ecom_str, ':');
-
-                               if (!vni_str)
-                                       continue; /* This should never happen */
+                               if (!vni_str) {
+                                       XFREE(MTYPE_ECOMMUNITY_STR, ecom_str);
+                                       continue;
+                               }
 
                                /* Move pointer to vni */
                                vni_str += 1;