]> git.puffer.fish Git - mirror/frr.git/commitdiff
ospfd: Fix warn -> debug for neighbor add
authorDonald Sharp <sharpd@cumulusnetworks.com>
Tue, 21 Aug 2018 13:26:19 +0000 (09:26 -0400)
committerQuentin Young <qlyoung@cumulusnetworks.com>
Thu, 6 Sep 2018 20:50:58 +0000 (20:50 +0000)
If we detect we already have a neighbor, no need to
re-add so no need to warn since we do not do anything with
the data.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
ospfd/ospf_neighbor.c

index d647525eaa15321500ec2d37e60e838989384cfe..a0fe1c53ded415f67c791e544cdec927d13bce5d 100644 (file)
@@ -269,9 +269,10 @@ void ospf_nbr_add_self(struct ospf_interface *oi, struct in_addr router_id)
        rn = route_node_get(oi->nbrs, &p);
        if (rn->info) {
                /* There is already pseudo neighbor. */
-               zlog_warn(
-                       "router_id %s already present in neighbor table. node refcount %u",
-                       inet_ntoa(router_id), rn->lock);
+               if (IS_DEBUG_OSPF_EVENT)
+                       zlog_debug(
+                                  "router_id %s already present in neighbor table. node refcount %u",
+                                  inet_ntoa(router_id), rn->lock);
                route_unlock_node(rn);
        } else
                rn->info = oi->nbr_self;