]> git.puffer.fish Git - matthieu/frr.git/commitdiff
zebra: Display master interface names, not ifindices
authorDinesh G Dutt <5016467+ddutt@users.noreply.github.com>
Tue, 13 Aug 2019 16:28:16 +0000 (16:28 +0000)
committerDinesh G Dutt <5016467+ddutt@users.noreply.github.com>
Tue, 13 Aug 2019 16:28:16 +0000 (16:28 +0000)
    When displaying the master interface's information in "show interface",
    the display is currently the ifindex of the master interface. Make it
    display the name as well as that is more useful than the name.

Signed-off-by: Dinesh G Dutt<5016467+ddutt@users.noreply.github.com>
zebra/interface.c

index 732e900bbdee9280f17d7c76ba86b524f8666ccd..a2f80aff4e691101334561639e6b84b0ccc96359 100644 (file)
@@ -1382,26 +1382,35 @@ static void if_dump_vty(struct vty *vty, struct interface *ifp)
                struct zebra_l2info_brslave *br_slave;
 
                br_slave = &zebra_if->brslave_info;
-               if (br_slave->bridge_ifindex != IFINDEX_INTERNAL)
-                       vty_out(vty, "  Master (bridge) ifindex %u\n",
-                               br_slave->bridge_ifindex);
+               if (br_slave->bridge_ifindex != IFINDEX_INTERNAL) {
+                       if (br_slave->br_if)
+                               vty_out(vty, "  Master interface: %s\n",
+                                       br_slave->br_if->name);
+                       else
+                               vty_out(vty, "  Master ifindex: %u\n",
+                                       br_slave->bridge_ifindex);
+               }
        }
 
        if (IS_ZEBRA_IF_BOND_SLAVE(ifp)) {
                struct zebra_l2info_bondslave *bond_slave;
 
                bond_slave = &zebra_if->bondslave_info;
-               if (bond_slave->bond_ifindex != IFINDEX_INTERNAL)
-                       vty_out(vty, "  Master (bond) ifindex %u\n",
-                               bond_slave->bond_ifindex);
+               if (bond_slave->bond_ifindex != IFINDEX_INTERNAL) {
+                       if (bond_slave->bond_if)
+                               vty_out(vty, "  Master interface: %s\n",
+                                       bond_slave->bond_if->name);
+                       else
+                               vty_out(vty, "  Master ifindex: %u\n",
+                                       bond_slave->bond_ifindex);
+               }
        }
 
        if (zebra_if->link_ifindex != IFINDEX_INTERNAL) {
-               vty_out(vty, "  Link ifindex %u", zebra_if->link_ifindex);
                if (zebra_if->link)
-                       vty_out(vty, "(%s)\n", zebra_if->link->name);
+                       vty_out(vty, "  Parent interface: %s\n", zebra_if->link->name);
                else
-                       vty_out(vty, "(Unknown)\n");
+                       vty_out(vty, "  Parent ifindex: %d\n", zebra_if->link_ifindex);
        }
 
        if (HAS_LINK_PARAMS(ifp)) {