]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: fix version attribute is an int, not a string
authorPhilippe Guibert <philippe.guibert@6wind.com>
Mon, 25 Nov 2024 21:47:21 +0000 (22:47 +0100)
committerMergify <37929162+mergify[bot]@users.noreply.github.com>
Tue, 26 Nov 2024 13:30:13 +0000 (13:30 +0000)
The json display of the version attribute is originally an
integer. It has changed, most probably mistakenly.

> {
>   "vrfId": 7,
>   "vrfName": "vrf1",
>   "tableVersion": 3,
>   "routerId": "192.0.2.1",
>   "defaultLocPrf": 100,
>   "localAS": 65500,
>   "routes": {
>     "172.31.0.1/32": {
>       "prefix": "172.31.0.1/32",
>       "version": "1", <--- int or string ??

Let us fix it, by using the integer display instead.

Fixes: f9f2d188e398 ("bgpd: fix 'json detail' output structure")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
(cherry picked from commit c5d7815cccb92c192ca6b752843b8b827a607b53)

bgpd/bgp_route.c

index b4406cbf19b704519f9647e8b6d56ee688f7d2a0..9cadf61c4da75fab94e1fd78898b8761168a00c3 100644 (file)
@@ -12315,8 +12315,7 @@ void route_vty_out_detail_header(struct vty *vty, struct bgp *bgp,
                } else {
                        if (incremental_print) {
                                vty_out(vty, "\"prefix\": \"%pFX\",\n", p);
-                               vty_out(vty, "\"version\": \"%" PRIu64 "\",",
-                                       dest->version);
+                               vty_out(vty, "\"version\": %" PRIu64 ",", dest->version);
                        } else {
                                json_object_string_addf(json, "prefix", "%pFX",
                                                        p);