]> git.puffer.fish Git - mirror/frr.git/commitdiff
[bgpd] Small buffer overrun in bgp_clear_node_queue_init
authorNick Hilliard <nick@inex.ie>
Tue, 17 Mar 2009 22:14:25 +0000 (22:14 +0000)
committerPaul Jakma <paul@quagga.net>
Tue, 21 Jul 2009 10:34:27 +0000 (11:34 +0100)
* bgp_route.c: (bgp_clear_node_queue_init) fix buffer
  overrun.

bgpd/bgp_route.c

index 8dafd181e58a051f1a9fd07af07457facc7ee6b9..d08cb1e17cbaf9b9b9556db2e2be0bdf672a6b5c 100644 (file)
@@ -2726,8 +2726,7 @@ bgp_clear_node_complete (struct work_queue *wq)
 static void
 bgp_clear_node_queue_init (struct peer *peer)
 {
-#define CLEAR_QUEUE_NAME_LEN 26 /* "clear 2001:123:123:123::1" */
-  char wname[CLEAR_QUEUE_NAME_LEN];
+  char wname[sizeof("clear xxxx:xxxx:xxxx:xxxx:xxxx:xxxx:xxxx:xxxx"];
   
   snprintf (wname, CLEAR_QUEUE_NAME_LEN, "clear %s", peer->host);
 #undef CLEAR_QUEUE_NAME_LEN