]> git.puffer.fish Git - mirror/frr.git/commitdiff
build: -Werror does not belong in AM_CPPFLAGS
authorDavid Lamparter <equinox@diac24.net>
Sat, 18 Aug 2018 03:08:19 +0000 (05:08 +0200)
committerDavid Lamparter <equinox@diac24.net>
Thu, 25 Oct 2018 15:30:21 +0000 (17:30 +0200)
(probably neither do the ASAN/... FLAGS, but let's leave that alone.)

Also, it was intentional that it's $(WERROR) and not @WERROR@.  The
former can be overwritten at comandline as "make WERROR=" while the
latter can't.

Signed-off-by: David Lamparter <equinox@diac24.net>
common.am

index 73f36eed1a216a1de963b2e81143a025ecbdf3b8..9c0c5478111a04d64d3be9fc5e26e0b11595e145 100644 (file)
--- a/common.am
+++ b/common.am
@@ -2,8 +2,8 @@
 # Automake fragment intended to be shared by Makefile.am files in the
 # tree. When used, should be included at the very top of the file.
 #
-AM_CPPFLAGS = @ASAN_FLAGS@ @TSAN_FLAGS@ @MSAN_FLAGS@ @WERROR@
-AM_CFLAGS = @ASAN_FLAGS@ @TSAN_FLAGS@ @MSAN_FLAGS@ @WERROR@
+AM_CPPFLAGS = @ASAN_FLAGS@ @TSAN_FLAGS@ @MSAN_FLAGS@
+AM_CFLAGS = @ASAN_FLAGS@ @TSAN_FLAGS@ @MSAN_FLAGS@ $(WERROR)
 
 AM_V_CLIPPY = $(am__v_CLIPPY_$(V))
 am__v_CLIPPY_ = $(am__v_CLIPPY_$(AM_DEFAULT_VERBOSITY))