vrrpd: make useless assert useful

Assert would always come back true due to improper placement.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

diff --git a/vrrpd/vrrp_packet.c b/vrrpd/vrrp_packet.c
index 102750eafeb38e01380b76e258e952db13762f79..fcbea8f6952c855a8c05e45a0a862b71be256d8d 100644 (file)
--- a/vrrpd/vrrp_packet.c
+++ b/vrrpd/vrrp_packet.c
@@ -112,13 +112,14 @@ ssize_t vrrp_pkt_adver_build(struct vrrp_pkt **pkt, struct ipaddr *src,
        size_t addrsz = 0;
 
        assert(version >= 2 && version <= 3);
-       assert(!(version == 2 && v6));
 
        if (numip > 0) {
                v6 = IS_IPADDR_V6(ips[0]);
                addrsz = IPADDRSZ(ips[0]);
        }
 
+       assert(!(version == 2 && v6));
+
        size_t pktsize = VRRP_PKT_SIZE(v6 ? AF_INET6 : AF_INET, version, numip);
        *pkt = XCALLOC(MTYPE_VRRP_PKT, pktsize);