]> git.puffer.fish Git - matthieu/frr.git/commitdiff
pbrd: fix map seq installed flag in json
authorChirag Shah <chirag@nvidia.com>
Fri, 20 Oct 2023 05:07:15 +0000 (22:07 -0700)
committerMergify <37929162+mergify[bot]@users.noreply.github.com>
Wed, 6 Dec 2023 05:57:47 +0000 (05:57 +0000)
Ticket:#3638598
Testing:

Post fix:
tor-2# show pbr map json
[
  {
    "name":"global-vrf-PBR-map",
    "valid":true,
    "policies":[
      {
        "id":1,
        "sequenceNumber":10,
        "ruleNumber":309,
        "vrfUnchanged":false,
        "installed":true,   <<<< now display correct value
        "installedReason":"Valid",
        "vrfName":"sym_1",
        "matchSrc":"10.1.200.0\/24",
        "matchDst":"10.6.200.0\/24"
      }
    ]
  }

Signed-off-by: Chirag Shah <chirag@nvidia.com>
(cherry picked from commit 64745d413ccf0b87df540bcf9e8a2b1dcbb893e2)

pbrd/pbr_vty.c
tests/topotests/pbr_topo1/r1/pbr-map.json

index 0325c79c3ccd444af19ca2204e13cb645257b31c..105190abc9882bc57bd77920b073f9bb41aa1b12 100644 (file)
@@ -978,8 +978,7 @@ static void vty_json_pbrms(json_object *j, struct vty *vty,
        json_object_int_add(jpbrm, "sequenceNumber", pbrms->seqno);
        json_object_int_add(jpbrm, "ruleNumber", pbrms->ruleno);
        json_object_boolean_add(jpbrm, "vrfUnchanged", pbrms->vrf_unchanged);
-       json_object_boolean_add(jpbrm, "installed",
-                               pbr_nht_get_installed(nhg_name));
+       json_object_boolean_add(jpbrm, "installed", pbrms->installed);
        json_object_string_add(jpbrm, "installedReason",
                               pbrms->reason ? rbuf : "Valid");
 
index bfa0ecb849056aa08b812f891860c353df427c20..aaf2b5e8dc993e8c38728cf15d6e19c67c34561e 100644 (file)
@@ -18,7 +18,7 @@
       {
         "sequenceNumber":10,
         "vrfUnchanged":false,
-        "installed":true,
+        "installed":false,
         "installedReason":"Invalid Src or Dst",
         "nexthopGroup":{
           "name":"C",
@@ -98,7 +98,7 @@
       {
         "sequenceNumber":5,
         "vrfUnchanged":false,
-        "installed":false,
+        "installed":true,
         "installedReason":"Invalid NH-group",
         "nexthopGroup":{
           "name":"B",
       {
         "sequenceNumber":10,
         "vrfUnchanged":true,
-        "installed":false,
+        "installed":true,
         "installedReason":"Valid",
         "matchSrc":"1.2.0.0\/16",
         "matchDst":"3.4.5.0\/24"