This code didn't survive valgrinding. I wonder how it survived normal run.

diff --git a/isisd/ChangeLog b/isisd/ChangeLog
index 726593ab908d920f9f5fd0625c64eb6a5b60d10e..b95bdbf99dbfd743da9da78c0cba31455d4d4a2d 100644 (file)
--- a/isisd/ChangeLog
+++ b/isisd/ChangeLog
@@ -1,3 +1,7 @@
+2004-09-27 Hasso Tepper <hasso at quagga.net>
+
+       * isis_pdu.c: Fix accessing NULL found by valgrind.
+
 2004-09-26 Hasso Tepper <hasso at quagga.net>
 
        * isis_circuit.c: Fix previous commit. Don't schedule LSP regeneration

diff --git a/isisd/isis_pdu.c b/isisd/isis_pdu.c
index 436240efad906c764a1d9b503f3a63c02b28c777..3e5154c62e8dc22ebdbfbc6dc86d4d93eb71f0e6 100644 (file)
--- a/isisd/isis_pdu.c
+++ b/isisd/isis_pdu.c
@@ -141,6 +141,9 @@ ip_match (struct list *left, struct list *right)
   struct in_addr *ip2;
   struct listnode *node1, *node2;
 
+  if ((left == NULL) || (right == NULL))
+    return 0;
+  
   LIST_LOOP (left, ip1, node1)
   {
     LIST_LOOP (right, ip2, node2)