]> git.puffer.fish Git - mirror/frr.git/commitdiff
pimd,pim6d: Resolving the YANG datatype Inconsistency for PIM Hello Interval 14299/head
authorSai Gomathi N <nsaigomathi@vmware.com>
Wed, 30 Aug 2023 12:45:18 +0000 (05:45 -0700)
committerSai Gomathi N <nsaigomathi@vmware.com>
Wed, 30 Aug 2023 13:02:12 +0000 (06:02 -0700)
The YANG specification currently designates a uint8 data type for the hello interval,
despite the CLI documentation (ip pim hello (1-65535) [(1-65535)]) indicating a maximum value of 65535.
To address this inconsistency, updating the data type to uint16 allowing for a maximum value for hello intervals.

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
pimd/pim_nb_config.c
yang/frr-pim.yang

index 30d84710e6678d16cdfff18eeeb226459141c717..be05b69401e46c2a40193a6e670e64f6de674119 100644 (file)
@@ -1633,7 +1633,7 @@ int lib_interface_pim_address_family_hello_interval_modify(
                ifp = nb_running_get_entry(args->dnode, NULL, true);
                pim_ifp = ifp->info;
                pim_ifp->pim_hello_period =
-                       yang_dnode_get_uint8(args->dnode, NULL);
+                       yang_dnode_get_uint16(args->dnode, NULL);
                pim_ifp->pim_default_holdtime = -1;
                break;
        }
index 105dab895da536b2371a2b708e015abf733b8224..e9b3f675073d5f1cb2fa81ad80ff94b13a7110e5 100644 (file)
@@ -343,7 +343,7 @@ module frr-pim {
     }
 
     leaf hello-interval {
-      type uint8 {
+      type uint16 {
         range "1..max";
       }
       default "30";