bgpd: bgp_evpn_mh_route_delete should ensure dest is still usable

Again coverity believes that dest may be freed but it should not
be because of how locking is done.  Make coverity happy.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

diff --git a/bgpd/bgp_evpn_mh.c b/bgpd/bgp_evpn_mh.c
index 91db9a061a9ce152e24f6757ab368aad6df919c8..7700281cd2c65c7964bb2f0f511a29b1e88a142c 100644 (file)
--- a/bgpd/bgp_evpn_mh.c
+++ b/bgpd/bgp_evpn_mh.c
@@ -513,8 +513,11 @@ static int bgp_evpn_mh_route_delete(struct bgp *bgp, struct bgp_evpn_es *es,
         */
        delete_evpn_route_entry(bgp, afi, safi, dest, &pi);
        if (pi)
-               bgp_path_info_reap(dest, pi);
+               dest = bgp_path_info_reap(dest, pi);
+
+       assert(dest);
        bgp_dest_unlock_node(dest);
+
        return 0;
 }