bgpd: remove useless control checks about TCP connection

When attempting to get the src and destination addresses of a given
connection, the API may return the NULL pointer, but further code
in bgp_zebra_nexthop_set() already does a check about the given
pointer.

Relaxing the error code for all the returned adressing.

Fixes: 1ff9a340588a ("bgpd: bgpd-fsm-fix.patch")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
(cherry picked from commit ba7130309954fbe8d58854339ca43259149e603a)

diff --git a/bgpd/bgp_network.c b/bgpd/bgp_network.c
index b874e7211f9fb2c857988012b612a515283dfd36..f08881512a4b9b56a554bdb10f6e502d068ef113 100644 (file)
--- a/bgpd/bgp_network.c
+++ b/bgpd/bgp_network.c
@@ -876,11 +876,7 @@ int bgp_getsockname(struct peer *peer)
        }
 
        peer->su_local = sockunion_getsockname(peer->connection->fd);
-       if (!peer->su_local)
-               return -1;
        peer->su_remote = sockunion_getpeername(peer->connection->fd);
-       if (!peer->su_remote)
-               return -1;
 
        if (!bgp_zebra_nexthop_set(peer->su_local, peer->su_remote,
                                   &peer->nexthop, peer)) {