]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: Do not check for capability length for Link-Local Next Hop capability 18068/head
authorDonatas Abraitis <donatas@opensourcerouting.org>
Sat, 8 Feb 2025 11:01:01 +0000 (13:01 +0200)
committerDonatas Abraitis <donatas@opensourcerouting.org>
Sat, 8 Feb 2025 11:01:53 +0000 (13:01 +0200)
Capability's length is 0 and this is not needed to check if it's multiplied by
X or there is a minimum length for that.

Fixes: db853cc97eafee8742cd391aaa2b5bc58a6751ae ("bgpd: Implement Link-Local Next Hop capability")
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
bgpd/bgp_open.c
bgpd/bgp_packet.c

index be04d87b7443b9b026e6fefaa328eed1c9b5ae15..e03239f0146bc2307cfeb8a643e58b8320b4eb12 100644 (file)
@@ -1069,7 +1069,6 @@ static int bgp_capability_parse(struct peer *peer, size_t length,
                case CAPABILITY_CODE_ROLE:
                case CAPABILITY_CODE_SOFT_VERSION:
                case CAPABILITY_CODE_PATHS_LIMIT:
-               case CAPABILITY_CODE_LINK_LOCAL:
                        /* Check length. */
                        if (caphdr.length < cap_minsizes[caphdr.code]) {
                                zlog_info(
index 3e90d7881c5505d101b62aedf086cff87b38c1db..7e342dba26add45fa4b79f9fbd8e69f2e51a06d4 100644 (file)
@@ -3781,7 +3781,6 @@ static int bgp_capability_msg_parse(struct peer *peer, uint8_t *pnt,
                case CAPABILITY_CODE_ROLE:
                case CAPABILITY_CODE_SOFT_VERSION:
                case CAPABILITY_CODE_PATHS_LIMIT:
-               case CAPABILITY_CODE_LINK_LOCAL:
                        if (hdr->length < cap_minsizes[hdr->code]) {
                                zlog_info("%pBP: %s Capability length error: got %u, expected at least %u",
                                          peer, capability, hdr->length,