]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: remove vrf->iflist deleted to avoid a crash
authorDon Slice <dslice@cumulusnetworks.com>
Fri, 10 Jun 2016 13:58:03 +0000 (06:58 -0700)
committerDon Slice <dslice@cumulusnetworks.com>
Fri, 10 Jun 2016 13:58:03 +0000 (06:58 -0700)
Ticket: CM-11327
Signed-off-by: Don Slice
Reviewed-by: Donald Sharp
Testing Done: Manual testing, bgp-min, vrf-min, bgp-smoke, vrf-smoke all successful

When bgp was configured in a vrf and then deleted, the vrf->iflist
was being deleted from the vrf.  Since the vrf itself was not deleted,
it was assumed in later calls that the vrf->iflist was still there
and when it was referenced, the crash occurred.

bgpd/bgpd.c

index ed76cfcf603c4ccef0a7e13915fb71fa10e9e007..f23cc13725dcc5e23dd08671c33c01d4897da8e6 100644 (file)
@@ -7251,7 +7251,6 @@ bgp_if_finish (struct bgp *bgp)
       for (ALL_LIST_ELEMENTS (ifp->connected, c_node, c_nnode, c))
         bgp_connected_delete (bgp, c);
     }
-  vrf_iflist_terminate (bgp->vrf_id);
 }
 
 void