bgpd: remove redundant loopback check in label update

The "if_is_vrf" check is unnecessary because it’s already handled by
"if_get_vrf_loopback". Additionally, it ignores the default loopback and
could introduce potential bugs.

Fixes: 8b81f32e9787 ("bgpd: fix label lost when vrf loopback comes back")
Signed-off-by: Loïc Sang <loic.sang@6wind.com>

diff --git a/bgpd/bgp_mplsvpn.c b/bgpd/bgp_mplsvpn.c
index f7ca51e146383d0e8accdca2983902a8a3f5ec4a..ad774b2b008c0b2aa60bd1fd2fa4d0bfa6bb25db 100644 (file)
--- a/bgpd/bgp_mplsvpn.c
+++ b/bgpd/bgp_mplsvpn.c
@@ -304,7 +304,7 @@ void vpn_leak_zebra_vrf_label_update(struct bgp *bgp, afi_t afi)
 
        if (vpn_leak_to_vpn_active(bgp, afi, NULL, false)) {
                ifp = if_get_vrf_loopback(bgp->vrf_id);
-               if (ifp && if_is_vrf(ifp) && if_is_up(ifp))
+               if (ifp && if_is_up(ifp))
                        label = bgp->vpn_policy[afi].tovpn_label;
        }