lib: Coverity SA doesn't trust the CLI

Fix with some asserts to show Coverity SA that we mean
real(:trademark:) business.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

diff --git a/lib/filter.c b/lib/filter.c
index fe62ca1c13b48ff61d4b7b0c6677e4da6a3ddcaa..8c210bd7adf0ed5a55c40ff13ade0a3184bd94a2 100644 (file)
--- a/lib/filter.c
+++ b/lib/filter.c
@@ -1915,6 +1915,7 @@ DEFUN (mac_access_list,
        argv_find(argv, argc, "X:X:X:X:X:X", &idx);
        if (idx)
                mac = argv[idx]->arg;
+       assert(mac);
 
        return filter_set_zebra(vty, argv[2]->arg, seq, permit_deny, AFI_L2VPN,
                                mac, 0, 1);
@@ -1952,6 +1953,7 @@ DEFUN (no_mac_access_list,
        argv_find(argv, argc, "X:X:X:X:X:X", &idx);
        if (idx)
                mac = argv[idx]->arg;
+       assert(mac);
 
        return filter_set_zebra(vty, argv[2]->arg, seq, permit_deny, AFI_L2VPN,
                                mac, 0, 0);
@@ -2050,6 +2052,7 @@ DEFUN (access_list_exact,
        argv_find(argv, argc, "A.B.C.D/M", &idx);
        if (idx)
                prefix = argv[idx]->arg;
+       assert(prefix);
 
        idx = 0;
        if (argv_find(argv, argc, "exact-match", &idx))
@@ -2122,6 +2125,7 @@ DEFUN (no_access_list_exact,
        argv_find(argv, argc, "A.B.C.D/M", &idx);
        if (idx)
                prefix = argv[idx]->arg;
+       assert(prefix);
 
        idx = 0;
        if (argv_find(argv, argc, "exact-match", &idx))
@@ -2367,6 +2371,7 @@ DEFUN (no_ipv6_access_list_exact,
        argv_find(argv, argc, "X:X::X:X/M", &idx);
        if (idx)
                prefix = argv[idx]->arg;
+       assert(prefix);
 
        idx = 0;
        if (argv_find(argv, argc, "exact-match", &idx))